-
Notifications
You must be signed in to change notification settings - Fork 116
added grpc-web as an content type and mapped it to grpc-proto #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
i haven't actually tested it if this format is the same as grpc-proto but i thought it was since it says grpc in the content-type |
Good idea @nutterthanos! It would definitely be good to support this. It looks like the protocol is very closely related but not identical, although it's hard to tell at a glance whether the differences are important from our perspective. Do you have any good examples of sites using grpc-web I can use for testing? |
i don't have any atm unfortunately since not many api's or whatever seem to use that content-type |
for example there is this one that used it: for some weird reason there is application/grpc-web+proto as well but somehow that already can select gRPC as an content-type in the ui and that works note that comes from the Mcdonalds app in Australia tho there might be an similar one in the eu app too or whatever |
I haven't managed to reproduce any of these to test this unfortunately. Can you share a HAR with some grpc-web traffic? Or a website example would be best - really grpc-web is intended to be used as a compatibility form of gRPC for web browsers, so there must be some websites actually using it somewhere surely...?
Yep, that's expected, grpc does the same. The |
14f95d3
to
94d8c06
Compare
No description provided.